!feat: Add invartiants #101
Conversation
|
Can you add some tests |
|
@catShaark could you check this pr pls? |
| _, err = suite.msgServer.CreateValidator(suite.ctx, &msg) | ||
| suite.Require().NoError(err) | ||
|
|
||
| tc.malleate() |
There was a problem hiding this comment.
why there's no fail case in this test
There was a problem hiding this comment.
invariants should be success in any case
There was a problem hiding this comment.
there should be fail case in test, just set data in the store that causes it to fail
| name string | ||
| malleate func() | ||
| expError bool | ||
| }{ |
There was a problem hiding this comment.
there's no fail case for this test
There was a problem hiding this comment.
This is different test for check the store, not related in invariants. We should continue this test in different PR
There was a problem hiding this comment.
there should be fail case anyway because there is tc.expError.
There was a problem hiding this comment.
If so I think we should move it to a separate PR
There was a problem hiding this comment.
it's okay to put the test in this pr
This PR should be merge after #111